Fixed Form UrlEncoded OAuth Lib Core #1382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrants
commented
Jan 2, 2024
oauth2_provider/oauth2_backends.py
Outdated
| # if request.content_type in ['multipart/form-data', 'application/x-www-form-urlencoded']: | ||
| if request.content_type in ["application/x-www-form-urlencoded"]: | ||
| query_string = base64.b64decode(request.body).decode("utf-8") | ||
| query_params = {p.split("=")[0]: p.split("=")[1] for p in query_string.split("&")} |
ferrants
commented
Jan 2, 2024
ferrants
commented
Jan 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1382 +/- ##
==========================================
- Coverage 97.56% 97.15% -0.41%
==========================================
Files 32 32
Lines 2132 2143 +11
==========================================
+ Hits 2080 2082 +2
- Misses 52 61 +9 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
|
@ferrants thanks for opening the PR. We really need a test demonstrating the error and testing the fix. There are also the remainiing itms on the check list. Do you have time to complete this work? |
Author
|
This was two years ago. I don't recall. Close if you want, I don't care |
Member
|
Thanks for getting back to me. I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
Description of the Change
Adds another Oauth Lib Core that isn't broken for base64 encoded form submissions.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS